Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Update cacheFactory.js - #6068

Closed
jesselpalmer wants to merge 1 commit into
angular:masterfrom
jesselpalmer:patch-6
Closed

jesselpalmer wants to merge 1 commit into
angular:masterfrom
jesselpalmer:patch-6

Conversation

@jesselpalmer

Copy link
Copy Markdown
Member

Updated example formatting.

Updated example formatting.
@caitp

caitp commented Jan 31, 2014

Copy link
Copy Markdown
Contributor

https://gist.github.com/caitp/f289cecaa6983a663c64 I've edited this to look a bit more complete (because the demo gets rendered underneath it the source).

So, I'm a bit iffy about merging this immediately, because we're migrating the doc generation stuff over, and there's a bug in the current doc gen stuff which hides the closing </script> tag, making it a poor example.

Once that stuff is pulled in I'll merge if it looks okay.


Also, don't worry about closing and re-opening the pull request, it's fine :)

@jesselpalmer

Copy link
Copy Markdown
Member Author

Sounds good. Thank you!

@btford

btford commented Mar 17, 2014

Copy link
Copy Markdown
Contributor

@caitp what do you think about this now?

@btford btford added this to the Backlog milestone Mar 17, 2014
@caitp

caitp commented Mar 18, 2014

Copy link
Copy Markdown
Contributor

I think maybe using the live example format is not the best choice, because the example window is really big (bigger than it needs to be), and it's not showing anything very helpful. Maybe it would be good to fix this once there's a way to have more control over it.

I think I'm going to convert this to GFM-style example and merge it, it looks okay to me

@caitp caitp closed this in 2ca6d65 Mar 18, 2014
vojtajina pushed a commit that referenced this pull request Mar 21, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants